Re: [PATCH 1/2] Move the pick_author code to git-sh-setup

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 24, 2007, 06:39 UTC
Message-ID: <7v7ipt3lh6.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0706240000340.4059@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 5 quoted lines

> -	set_author_env=`git show -s --pretty=raw --encoding="$encoding" "$use_commit" |
> -	LANG=C LC_ALL=C sed -ne "$pick_author_script"`
> -	eval "$set_author_env"
> ...
> +	eval $(get_author_ident_from_commit "$use_commit")

Are you sure about this part of the change? I suspect that you are losing IFS by not dq'ing the argument you give to the eval.

    #!/bin/sh

    test1 () {
        echo "$1=' d  e'"
    }

    eval $(test1 A)
    eval "$(test1 B)"
    echo "A=$A"
    echo "B=$B"