Re: [PATCH 1/2] Move the pick_author code to git-sh-setup

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 24, 2007, 11:14 UTC
Message-ID: <7vd4zlvc3r.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0706241118250.4059@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 6 quoted lines

> That is well possible. Quoting in shell is such a hassle, and I never seem 
> to get it right.
>
> Therefore I did a minimal test,...
>
> So I thought that it was okay.

Try the small test script in the message you are responding to. It gives me:

        $ sh ./1.sh
        A= d e
        B= d  e

A quick rule of thumb is that the only place that you can get away by not quoting is straight assignment to another variable, like so:

	var='a  b c '
        another=$var	;# another="$var" is fine but unnecessary.

Similarly for

	another=$(some command)

which is Ok not to dquote.