Re: That improved git-gui blame viewer..

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 13, 2007, 18:34 UTC
Message-ID: <Pine.LNX.4.64.0706131931410.4059@racer.site>
In-Reply-To: <200706132017.31379.Josef.Weidendorfer@gmx.de>

Hi,

On Wed, 13 Jun 2007, Josef Weidendorfer wrote:

Show 5 quoted lines

> On Wednesday 13 June 2007, Johannes Schindelin wrote:
> > So, I should have realized earlier that "git-log -z" _without_ anything in 
> > the way of "-p", "--stat" or friends does not make sense at all.
> 
> But it does make sense: it separates commits using '\0'.

Indeed, I missed that. Of course, you could do something as simple as this, although it looks really hacky to me:

diff --git a/revision.c b/revision.c
index b12c25e..1f4590b 100644
--- a/revision.c
+++ b/revision.c
@@ -1180,7 +1180,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
 
 			opts = diff_opt_parse(&revs->diffopt, argv+i, argc-i);
 			if (opts > 0) {
-				revs->diff = 1;
+				if (strcmp(argv[i], "-z"))
+					revs->diff = 1;
 				i += opts - 1;
 				continue;
 			}

Ciao,
Dscho