Re: That improved git-gui blame viewer..

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 13, 2007, 17:05 UTC
Message-ID: <Pine.LNX.4.64.0706131804080.4059@racer.site>
In-Reply-To: <200706131854.59605.Josef.Weidendorfer@gmx.de>

Hi,

On Wed, 13 Jun 2007, Josef Weidendorfer wrote:

Show 11 quoted lines

> opt->diff is set to 1 in setup_revisions() whenever
> diff_opt_parse() parses an option. And "-z" is
> parsed in diff_opt_parse().
> 
> In cd2bdc, Linus write in the commit log
> 
>  - make setup_revision set a flag (revs->diff) if the diff-related
>    arguments were used. This allows "git log" to decide whether it wants
>    to show diffs or not.
> 
> So why is "-z" regarded as tree-diff related, leading to calculating diffs?

Because it changes the behaviour of a diff. As far as I can tell, the line termination does not have any effect on any output _except_ the diff output.

So, I should have realized earlier that "git-log -z" _without_ anything in the way of "-p", "--stat" or friends does not make sense at all.

Ciao, Dscho