Re: That improved git-gui blame viewer..
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 13, 2007, 17:17 UTC
- Message-ID
- <7v8xanepto.fsf@assigned-by-dhcp.pobox.com>
- In-Reply-To
- <200706131854.59605.Josef.Weidendorfer@gmx.de>
Josef Weidendorfer <Josef.Weidendorfer@gmx.de> writes:
Show 22 quoted lines
> On Wednesday 13 June 2007, Josef Weidendorfer wrote: >> While without "-z", log_tree_diff immediatly returns >> because "opt->diff" is 0, in the case of "-z", >> the tree differences are fully done even not used at all ?! > > I wished git-gui and gitk would be better integrated for > history/blame browsing; I also missed a text search functionality > in the blame view of git-gui. > > Neverless... > > opt->diff is set to 1 in setup_revisions() whenever > diff_opt_parse() parses an option. And "-z" is > parsed in diff_opt_parse(). > > In cd2bdc, Linus write in the commit log > > - make setup_revision set a flag (revs->diff) if the diff-related > arguments were used. This allows "git log" to decide whether it wants > to show diffs or not. > > So why is "-z" regarded as tree-diff related, leading to calculating diffs?
Because of the thinko in that commit. He obviously meant things like --stat, -p and its friends.