git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: That improved git-gui blame viewer..

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 13, 2007, 17:17 UTC
Message-ID
<7v8xanepto.fsf@assigned-by-dhcp.pobox.com>
In-Reply-To
<200706131854.59605.Josef.Weidendorfer@gmx.de>
Josef Weidendorfer <Josef.Weidendorfer@gmx.de> writes:
Show 22 quoted lines
> On Wednesday 13 June 2007, Josef Weidendorfer wrote:
>> While without "-z", log_tree_diff immediatly returns
>> because "opt->diff" is 0, in the case of "-z",
>> the tree differences are fully done even not used at all ?!
>
> I wished git-gui and gitk would be better integrated for
> history/blame browsing; I also missed a text search functionality
> in the blame view of git-gui.
>
> Neverless...
>
> opt->diff is set to 1 in setup_revisions() whenever
> diff_opt_parse() parses an option. And "-z" is
> parsed in diff_opt_parse().
>
> In cd2bdc, Linus write in the commit log
>
>  - make setup_revision set a flag (revs->diff) if the diff-related
>    arguments were used. This allows "git log" to decide whether it wants
>    to show diffs or not.
>
> So why is "-z" regarded as tree-diff related, leading to calculating diffs?

Because of the thinko in that commit. He obviously meant things like --stat, -p and its friends.

Previous: Johannes SchindelinNext: Shawn O. Pearce
Message 25 of 29 in “That improved git-gui blame viewer..”
  1. Linus TorvaldsJun 9, 2007
  2. Junio C HamanoJun 9, 2007
  3. Shawn O. PearceJun 11, 2007
  4. Linus TorvaldsJun 11, 2007
  5. Junio C HamanoJun 11, 2007
  6. Marco CostalbaJun 12, 2007
  7. Junio C HamanoJun 12, 2007
  8. Marco CostalbaJun 12, 2007
  9. Marco CostalbaJun 12, 2007
  10. Shawn O. PearceJun 12, 2007
  11. Junio C HamanoJun 12, 2007
  12. Marco CostalbaJun 13, 2007
  13. Marco CostalbaJun 13, 2007
  14. Johannes SchindelinJun 13, 2007
  15. Marco CostalbaJun 13, 2007
  16. Johannes SchindelinJun 13, 2007
  17. Marco CostalbaJun 13, 2007
  18. Johannes SchindelinJun 13, 2007
  19. Josef WeidendorferJun 13, 2007
  20. Johannes SchindelinJun 13, 2007
  21. Josef WeidendorferJun 13, 2007
  22. Johannes SchindelinJun 13, 2007
  23. Josef WeidendorferJun 13, 2007
  24. Johannes SchindelinJun 13, 2007
  25. Junio C HamanoJun 13, 2007
  26. Shawn O. PearceJun 14, 2007
  27. Jakub NarebskiJun 13, 2007
  28. Marco CostalbaJun 14, 2007
  29. Marco CostalbaJun 13, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.