Re: [PATCH] Make the installation targets a little less chatty

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 4, 2007, 17:40 UTC
Message-ID: <Pine.LNX.4.64.0706041840460.4046@racer.site>
In-Reply-To: <81b0412b0706040700s667afe5ap14a8343a9313ef60@mail.gmail.com>

Hi,

On Mon, 4 Jun 2007, Alex Riesen wrote:

Show 27 quoted lines

> On 6/4/07, Junio C Hamano <gitster@pobox.com> wrote:
> > >
> > > Updated. BTW, where does "no $(call) in Makefile" came from?
> > > It could simplify the thing a lot
> > 
> > Probably, but first let's make it "work right" while not
> > introducing new stuff.
> > 
> 
> Just looked for the reasons, which appear to be there:
> commit 39c015c556f285106931e0500f301de462b0e46e
> Author: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Date:   Sat Feb 18 12:40:22 2006 +0100
> 
>    Fixes for ancient versions of GNU make
> 
>    Some versions of GNU make do not understand $(call), and have problems to
>    interpret rules like this:
> 
>    some_target: CFLAGS += -Dsome=defs
> 
>    [jc: simplified substitution a bit. ]
> 
>    Signed-off-by: Johannes E. Schindelin <Johannes.Schindelin@gmx.de>
>    Signed-off-by: Junio C Hamano <junkio@cox.net>
> 
> I trust Johannes to have such a make, never seen it myself, though.

Yes. I no longer have access to that machine, but it was an SGI machine running IRIX, and I had no root access, and I had a quota.

That is when I worked towards getting rid of Python (making the use of it optional at first), and working with incompatible or sufficiently non-GNU programs like old make, different sed, etc.

At the time I was really annoyed with the situation, especially since it was _easy_ to stay compatible with them. I have little sympathy with making things just a little simpler for John R. Developer, and substantially harder for a lot of users.

So, are you sure you want to force everybody who wants to compile Git to use a recent GNU make?

Ciao, Dscho