Re: [PATCH] Make the installation targets a little less chatty

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jun 4, 2007, 14:00 UTC
Message-ID: <81b0412b0706040700s667afe5ap14a8343a9313ef60@mail.gmail.com>
In-Reply-To: <7vvee4jh24.fsf@assigned-by-dhcp.cox.net>

On 6/4/07, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> >
> > Updated. BTW, where does "no $(call) in Makefile" came from?
> > It could simplify the thing a lot
>
> Probably, but first let's make it "work right" while not
> introducing new stuff.
>

Just looked for the reasons, which appear to be there:
commit 39c015c556f285106931e0500f301de462b0e46e
Author: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Date:   Sat Feb 18 12:40:22 2006 +0100

    Fixes for ancient versions of GNU make

    Some versions of GNU make do not understand $(call), and have problems to
    interpret rules like this:

    some_target: CFLAGS += -Dsome=defs

    [jc: simplified substitution a bit. ]

    Signed-off-by: Johannes E. Schindelin <Johannes.Schindelin@gmx.de>
    Signed-off-by: Junio C Hamano <junkio@cox.net>

I trust Johannes to have such a make, never seen it myself, though.

Show 7 quoted lines

> >  install: all
> >       $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(bindir_SQ)'
> >       $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
>
> I found Shawn's "DEST = $this_directory" quite decent.  Forgot
> to port it?
>

Race condition. Hit the send button before reading his patch and the related discussion. Besides, now I find it is already too much cruft just to print a directory. Didn't want to make it pretty, just needed some readability on screen. Still think the errors of (eventually) failing install would be enough.

Using $(call) would allow to generalize that, BTW.