Re: [PATCH] Make the installation targets a little less chatty
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 4, 2007, 07:48 UTC
- Message-ID
- <7vvee4jh24.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20070603130745.GC2495@steel.home>
Alex Riesen <raa.lkml@gmail.com> writes:
Show 7 quoted lines
> by default. V=1 works as usual. > > Signed-off-by: Alex Riesen <raa.lkml@gmail.com> > --- > > Updated. BTW, where does "no $(call) in Makefile" came from? > It could simplify the thing a lot
Probably, but first let's make it "work right" while not introducing new stuff.
Show 29 quoted lines
> diff --git a/Makefile b/Makefile > index cac0a4a..6409b9c 100644 > --- a/Makefile > +++ b/Makefile > ... > @@ -972,34 +975,53 @@ check: common-cmds.h > > ### Installation rules > > +ifeq ($(QUIET),@) > +INST_0 = arg= > +INST_1 = &&echo " INSTALL $$arg"&&$(INSTALL) "$$arg" # space > +BSETUP_0 = arg= > +BSETUP_1 = &&echo " SETUP BUILTIN $$arg"&& \ > + rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/'"$$arg" && \ > + ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git$(X)' \ > + '$(DESTDIR_SQ)$(gitexecdir_SQ)/'"$$arg" # space > +else > +INST_0 = $(INSTALL) # space to separate "install" and its first arg > +INST_1 = > +BSETUP_0 = arg= > +BSETUP_1 = &&rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/'"$$arg" && \ > + ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git$(X)' \ > + '$(DESTDIR_SQ)$(gitexecdir_SQ)/'"$$arg" # space > +endif > + > install: all > $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(bindir_SQ)' > $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
I found Shawn's "DEST = $this_directory" quite decent. Forgot to port it?