Re: [PATCH 3/6] Add 'resolve_gitlink_ref()' helper function

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Apr 10, 2007, 14:58 UTC
Message-ID: <Pine.LNX.4.64.0704100756060.6730@woody.linux-foundation.org>
In-Reply-To: <81b0412b0704100238l38ad3765w6c06878e2db654a7@mail.gmail.com>

On Tue, 10 Apr 2007, Alex Riesen wrote:

Show 17 quoted lines

>
> On 4/10/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > +int resolve_gitlink_ref(const char *path, const char *refname, unsigned
> > char *result)
> > +{
> > +       int len = strlen(path), retval;
> > +       char *gitdir;
> > +
> > +       while (len && path[len-1] == '/')
> > +               len--;
> > +       if (!len)
> > +               return -1;
> > +       gitdir = xmalloc(len + MAXREFLEN + 8);
> > +       memcpy(gitdir, path, len);
> > +       memcpy(gitdir + len, "/.git/", 7);
> 
> Can't a subproject be bare?

Not when it is checked out, no. That's what "checked out" means ;)

If a subproject is bare, it never gets resolved, because it's never checked out in a superproject.

So a subproject *can* be bare, but when it's bare it is just a totally regular independent git project, simply by *definition* of not being checked out inside a superproject.

But hey, that was just a design decision of mine, and if people can argue for it being wrong, I don't think I'm married to it ;)

		Linus