Re: [PATCH 0/6] Initial subproject support (RFC?)

From: Martin Waitz <tali@admingilde.org>
Date: Apr 11, 2007, 08:57 UTC
Message-ID: <20070411085755.GI21701@admingilde.org>
In-Reply-To: <81b0412b0704110142l377231d7j85285a87ef73ce41@mail.gmail.com>

hoi :)

On Wed, Apr 11, 2007 at 10:42:57AM +0200, Alex Riesen wrote:

Show 8 quoted lines

> On 4/11/07, Martin Waitz <tali@admingilde.org> wrote:
> >> The other thing which will be missed a lot (I miss it that much)
> >> is a subproject-recursive git-commit and git-status.
> >
> >git-status should really point out if a subproject has any changes,
> 
> Only if I want it to. HEAD change check (which is cheap enough
> to be done unconditionally) can be done always.

Yes, that's the equivalent of checking normal files. The recursive check for dirty files/index should be configurable.

Show 9 quoted lines

> >But for commit it really does not make any sense.  The commit in the
> >submodule is totally independent to the commit in the supermodule.
> 
> Right. Perhaps not a commit in submodule but a recursive check
> for working directory changes in submodules. So that you can
> make that you don't make a superproject commit which cannot
> be resolved to what you had in all the working directories:
> 
>  git commit -a --check-clean-subprojects

For -a such a check may even make sense unconditionally. And without -a I don't see any value in such a check. So we can just add that check to -a if we see that dirty submodules are a problem for users.

-- 
Martin Waitz