Re: [PATCH 6/6] Teach core object handling functions about gitlinks
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Apr 10, 2007, 11:31 UTC
- Message-ID
- <81b0412b0704100431i1e58c74tbe19ea490e470b8b@mail.gmail.com>
- In-Reply-To
- <20070410084022.GB2813@planck.djpig.de>
On 4/10/07, Frank Lichtenheld <frank@lichtenheld.de> wrote:
Show 10 quoted lines
> On Mon, Apr 09, 2007 at 09:20:29PM -0700, Linus Torvalds wrote:
> > + case S_IFDIR:
> > + return resolve_gitlink_ref(path, "HEAD", sha1);
> > default:
> > return error("%s: unsupported file type", path);
> > }
>
> Not that I have time right now to look up the exact context (only read
> the patch), but I would've expected a "case S_IFDIRLNK:" here?
>No, the st_mode comes directly from file system. It knows nothing about dirlinks.