Re: [PATCH] fetch--tool: fix uninitialized buffer when reading from stdin

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Feb 26, 2007, 18:05 UTC
Message-ID: <Pine.LNX.4.64.0702261003480.12485@woody.linux-foundation.org>
In-Reply-To: <Pine.LNX.4.63.0702261827510.22628@wbgn013.biozentrum.uni-wuerzburg.de>

On Mon, 26 Feb 2007, Johannes Schindelin wrote:

Show 8 quoted lines

> Hi,
> 
> On Mon, 26 Feb 2007, Linus Torvalds wrote:
> 
> > I suspect you only tested with small input to stdin.
> 
> Addendum: yes, I only tested with a reflist which was smaller than one 
> megabyte ;-)

Well, that CHUNK_SIZE is just silly. I don't see why you'd have a chunk-size of a megabyte to begin with, IO doesn't really get any more efficient that way. And yeah, in this case it would easily hide the bug, because in practice nobody would ever test with that much input data.

It might make sense to make the chunk-size smaller just from a testability standpoint (not to mention that it's probably currently just wasting memory for most users - although at least under Linux, if you never use a page, none will be allocated for you, so the OS may hide the wastage).

		Linus