Re: [PATCH] fetch--tool: fix uninitialized buffer when reading from stdin

From: Junio C Hamano <junkio@cox.net>
Date: Feb 26, 2007, 19:21 UTC
Message-ID: <7vk5y4n2qw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0702261003480.12485@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 13 quoted lines

> On Mon, 26 Feb 2007, Johannes Schindelin wrote:
>
>> Hi,
>> 
>> On Mon, 26 Feb 2007, Linus Torvalds wrote:
>> 
>> > I suspect you only tested with small input to stdin.
>> 
>> Addendum: yes, I only tested with a reflist which was smaller than one 
>> megabyte ;-)
>
> Well, that CHUNK_SIZE is just silly. I don't see why you'd have a 
> chunk-size of a megabyte to begin with,...

Me neither (not my code) ;-). I agree with you that using smaller limit than what will be deployed often helps testability.