git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch--tool: fix uninitialized buffer when reading from stdin

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Feb 26, 2007, 17:06 UTC
Message-ID
<Pine.LNX.4.64.0702260905420.12485@woody.linux-foundation.org>
In-Reply-To
<Pine.LNX.4.63.0702261741360.22628@wbgn013.biozentrum.uni-wuerzburg.de>
On Mon, 26 Feb 2007, Johannes Schindelin wrote:
> 
> But I agree your patch is saner.

Well, it's not the "saner" I'm worried about, I was more worried about the fact that your patch added random '\0' characters in the middle of the stdin input if it was ever bigger than CHUNK_SIZE. I suspect you only tested with small input to stdin.

			Linus
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 4 of 10 in “fetch--tool: fix uninitialized buffer when reading from stdin”
  1. fetch--tool: fix uninitialized buffer when reading from stdinJohannes Schindelin, Feb 26, 2007
  2. Linus TorvaldsFeb 26, 2007
  3. Johannes SchindelinFeb 26, 2007
  4. Linus TorvaldsFeb 26, 2007
  5. Johannes SchindelinFeb 26, 2007
  6. Johannes SchindelinFeb 26, 2007
  7. Linus TorvaldsFeb 26, 2007
  8. Junio C HamanoFeb 26, 2007
  9. Junio C HamanoFeb 26, 2007
  10. Johannes SchindelinFeb 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.