Re: git-fast-import

From: Nicolas Pitre <nico@cam.org>
Date: Feb 6, 2007, 04:06 UTC
Message-ID: <Pine.LNX.4.64.0702052248070.19212@xanadu.home>
In-Reply-To: <20070206023111.GB9222@spearce.org>

On Mon, 5 Feb 2007, Shawn O. Pearce wrote:

> I'm particularly interested in feedback on the documentation,
> so I am attaching it below.
>

[...]

Show 7 quoted lines

> 
> The time of the change is specified by `<time>` as the number of
> seconds since the UNIX epoc (midnight, Jan 1, 1970, UTC) and is
> written in base-10 notation using US-ASCII digits.  The committer's
> timezone is specified by `<tz>` as a positive or negative offset
> from UTC, in minutes.  For example EST would be expressed in `<tz>`
> by ``-0500''.

I think this is quite error prone, demonstrated by the fact that we screwed that up ourselves on a few occasions. I think that the frontend should be relieved from this by letting it provide the time of change in a more natural format amongst all possible ones(like RFC2822 for example) and gfi should simply give it to parse_date().

Otherwise I think this is pretty nice.

Nicolas