Re: git-fast-import

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 6, 2007, 09:40 UTC
Message-ID: <20070206094048.GE10508@spearce.org>
In-Reply-To: <200702060928.54440.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> wrote:

Show 13 quoted lines

> On Tuesday 2007 February 06 02:31, Shawn O. Pearce wrote:
> 
> > The time of the change is specified by `<time>` as the number of
> > seconds since the UNIX epoc (midnight, Jan 1, 1970, UTC) and is
> > written in base-10 notation using US-ASCII digits.  The committer's
> > timezone is specified by `<tz>` as a positive or negative offset
> > from UTC, in minutes.  For example EST would be expressed in `<tz>`
> > by ``-0500''.
> 
> Is <tz> /really/ expressed in minutes?  500 minutes is 8 hours 20 minutes.
> 
> I know what you mean, of course; and so would anyone reading it - so I suggest 
> just dropping the ", in minutes" - as it's not true.

Heh, right you are!

Nico's point about using parse_date() here is a really good one. I'm going to modify that section of gfi to use parse_date(), which would change the language here anyway. I'll try to not to make a silly mistake such as the above in the updated docs. :)

-- 
Shawn.