Re: [PATCH] Make sure git_connect() always give two file descriptors.

From: Linus Torvalds <torvalds@osdl.org>
Date: Jan 22, 2007, 01:47 UTC
Message-ID: <Pine.LNX.4.64.0701211744140.14248@woody.osdl.org>
In-Reply-To: <7v3b63zx0k.fsf_-_@assigned-by-dhcp.cox.net>

On Sun, 21 Jan 2007, Junio C Hamano wrote:

Show 5 quoted lines

>
> Earlier, git_connect() returned the same fd when the destination
> was remote (i.e.  we used socket to communicate with it) and two
> separate fds when the destination was local (i.e. we used
> pipe(2)).

Actually, to be strictly correct, we returned the same fd when

 - we used git:// and were not proxying

and we returned two different fd's for all other cases (ie local, ssh, proxy-git).

So it's not really about "remote" vs "local", since ssh in particular is mostly remote too, but since we used pipes to connect with ssh, it acted the same way as the local case (which also used pipes to connect to the local processes).

And git:// with proxy support also ended up using pipes (for the proxy process), which is why you _only_ saw this with the raw direct TCP git:// case.

Or something like that.-

		Linus