Re: git-push through git protocol

From: Bill Lear <rael@zopyra.com>
Date: Jan 21, 2007, 21:22 UTC
Message-ID: <17843.55730.456139.247155@lisa.zopyra.com>
In-Reply-To: <Pine.LNX.4.64.0701211034490.14248@woody.osdl.org>

I did the steenking testing and it appears to fail. This is with 1.4.4.1 (applied the patch by hand to daemon.c, rebuilt and installed on my local workstation). I get this (clone worked fine) on my test repo:

% git push git://localhost/fongo
updating 'refs/heads/master'
  from a54b51ffc155737d8ccebd645f0d2036072d669f
  to   c5599ebdeae970eaa0163374a6c5d8b216fc390a
fatal: read error (Bad file descriptor)
Generating pack...
Done counting 5 objects.
Result has 3 objects.
Deltifying 3 objects.
 100% (3/3) done
Writing 3 objects.
 100% (3/3) done
fatal: sha1 file '<stdout>' write error (Bad file descriptor)

My /etc/xinet.d/git-daemon looks like this:

service git
{
        disable         = no
        type            = UNLISTED
        port            = 9418
        socket_type     = stream
        wait            = no
        user            = nobody
        server          = /usr/bin/git-daemon
        server_args     = --enable=receive-pack --verbose --syslog --inetd --export-all --base-path=/repos/git
        log_on_failure  += USERID
}

Will try to dig into this more if I can...

Bill

On Sunday, January 21, 2007 at 11:04:13 (-0800) Linus Torvalds writes:

Show 16 quoted lines

>
>
>On Sun, 21 Jan 2007, Jakub Narebski wrote:
>> > 
>> > It seems there should be a way to configure a repo or the git daemon
>> > to say "Allow push operations".
>> > 
>> > I looked through the release notes Junio posted for 1.5.0-rc2, but
>> > found no reference to the git daemon.
>> 
>> git:// protocol is not authenticated. git by design allow push only through
>> authenticated protocols, i.e. local, ssh:// (git+ssh://), http(s):// with
>> WebDAV, probably in the future ftps://. 
>
>Well, it _should_ actually be truly fairly trivial to allow pushing over 
>the git:// protocol, ...