Re: [PATCH] pack-objects: use of version 3 delta is now optional.
- From
Nicolas Pitre <nico@cam.org>
- Date
- Oct 16, 2006, 13:27 UTC
- Message-ID
- <Pine.LNX.4.64.0610160925580.17085@xanadu.home>
- In-Reply-To
- <7v64ekyikn.fsf@assigned-by-dhcp.cox.net>
On Sun, 15 Oct 2006, Junio C Hamano wrote:
Show 11 quoted lines
> Nicolas Pitre <nico@cam.org> writes: > > > As for pack v4... My opinion is that nothing justifies it so far. So if > > I can convince Junio there shouldn't be any v4 just yet. > > The only concern I have is the commit walkers (rsync has the > same problem as well but we honestly do not care). They just > grab existing packs and try to use them. I have been wondering > if it might be safer to mark the delta-base-offset encoded packs > v4 to make sure the clients would get "I know only v2 and v3 but > you fed me v4" message.
It'll get "this pack contains an unknown object type" kind of message, which is almost as good IMHO, with the same end result.
Nicolas