Re: [PATCH] pack-objects: use of version 3 delta is now optional.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Oct 16, 2006, 04:45 UTC
- Message-ID
- <7v64ekyikn.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0610151433310.17085@xanadu.home>
Nicolas Pitre <nico@cam.org> writes:
> As for pack v4... My opinion is that nothing justifies it so far. So if > I can convince Junio there shouldn't be any v4 just yet.
The only concern I have is the commit walkers (rsync has the same problem as well but we honestly do not care). They just grab existing packs and try to use them. I have been wondering if it might be safer to mark the delta-base-offset encoded packs v4 to make sure the clients would get "I know only v2 and v3 but you fed me v4" message.
People who own public repositories and who care about commit walkers need to refrain from using delta-base-offset when repacking (which can be done via configuration mechanism already).
If download goes over git native protocol, there is no such worry -- they can pack using delta-base-offset and older clients will be fed a pack with 20-byte base object name just fine, so my worry is really only about commit walkers.