Re: [PATCH] pack-objects: use of version 3 delta is now optional.

From: Junio C Hamano <junkio@cox.net>
Date: Oct 15, 2006, 18:10 UTC
Message-ID: <7vac3xzbze.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0610151135110.17085@xanadu.home>

Nicolas Pitre <nico@cam.org> writes:

Show 9 quoted lines

> On Sun, 15 Oct 2006, Junio C Hamano wrote:
>
>> This introduces a new configuration item, pack.deltaversion, to
>> control whether pack-objects is allowed to use version 3 delta.
>> By default, we keep generating version 2 delta (and version 2
>> packfile format) to be compatible with git earlier than v1.2.0.
>...
> I'd suggest to drop this altogether.  See my previous email for my 
> reasoning on this issue.  I think this should be done another way.

I'll think about it a bit.

Show 5 quoted lines

> If anything, maybe this patch can be added before v1.4.3 is released:
>...
> This way pack v3 could be fed to GIT v1.4.3 and above whenever we add 
> back pack v3 generation, and a pack converted to v2 from any v3 on the 
> fly when that capability is not present.

I think that is sensible. I also was thinking that we should call the current one packv3 and the one with delta-base-offset packv4.