Re: [PATCH 1/2] diff --stat: use asymptotic scaling in graph

From: Nicolas Pitre <nico@cam.org>
Date: Oct 13, 2006, 00:39 UTC
Message-ID: <Pine.LNX.4.64.0610122038330.2435@xanadu.home>
In-Reply-To: <452EC625.7050301@gmail.com>

On Thu, 12 Oct 2006, A Large Angry SCM wrote:

Show 19 quoted lines

> Martin Waitz wrote:
> > On Thu, Oct 12, 2006 at 03:20:09PM -0700, A Large Angry SCM wrote:
> > > > +    if (it)
> > > > +        return it * width / (it + width) + 1;
> > > > +    else
> > > > +        return 0;
> > > No conditional needed:
> > >
> > >  return it * width / (it + width - 1)
> > 
> > But then it would start scaling much earlier
> > (for width 10: at 2 instead of 4).
> > This is not bad per se, but different...
> > 
> 
> OK:
> 	return (it * width + (it + width)/2)) / (it + width - 1)
> 
> Now it's back at 4. ;-)

Sure, but at this point the original conditional is probably more efficient.

Nicolas