Re: [PATCH 1/2] diff --stat: use asymptotic scaling in graph

From: Junio C Hamano <junkio@cox.net>
Date: Oct 14, 2006, 19:06 UTC
Message-ID: <7v7iz290py.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <d620685f0610130656u55079a1fkc2c98a82f3aa4a33@mail.gmail.com>

apodtele <apodtele@gmail.com> writes:

Show 11 quoted lines

> Before my patch is completely forgotten, let me critique the current
> approach. Currently everything is great and beautiful unless one
> particular change adds a couple of hundred lines, say, to a man page.
> With large changes in play, small changes are squashed to a single
> character. Would you argue that this scenario correctly represent
> importance of man pages? Would you say, that it's not misleading that
> 1-, 2-, and 5-liners all look the same as long as a man page is
> prominently shown? Moreover, 1-, 2-, and 5- liners may look different
> depending on the size of that man page. The current approach is not
> invariant; it is, however, normalized as needed. "Normalized" is good,
> "as needed" is bad.

One thing that mildly irritates me has been:

	git log --stat v2.6.17..

which, as you correctly point out, shows the bad effect of scaling per commit. "Normalized as needed" is good. What's bad is "not normalizing across things we show".

Even with your non-linear scaling, you would need to make sure every commit gets the same graph width; I do not think they currently do, due to name part scaling.

People are used to seeing the traditional diffstat output, so any improvement you make that is different from it (including e.g. "being able to show differences between 1- and 2- liner patch when a monster 800- liner happens to be in the same patch set", which is a worthwhile goal) will look bizarre and/or misleading to them and they would not like it.

With the change to align things in the middle, it might become easier to accept, because then it is _so_ obviously different from traditional diffstat, it is very clear to people that the output is different but still they can easily figure out that longer bars are for larger changes.

And this new output needs to be an option.