Re: [PATCH] pack-objects: re-validate data we copy from elsewhere.
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Sep 3, 2006, 22:00 UTC
- Message-ID
- <Pine.LNX.4.64.0609031456520.27779@g5.osdl.org>
- In-Reply-To
- <7vslj8tydc.fsf@assigned-by-dhcp.cox.net>
On Sun, 3 Sep 2006, Junio C Hamano wrote:
> > Quite bad. For the kernel archive of today (I usually am nearly > fully packed):
Ok. Is it less painful if it just checks the zlib CRC (and that the SHA1 _exists_ for a delta - although I guess we check that indirectly by just accepting the delta in the first place)? That combination should still be a fairly strong check, of course.
Then we could have something like
[repack] check=[none|weak|default|strong]
where the "none" check would be to just copy the data as-is, the "weak" (aka "default") would check just the CRC, and the strong one would unpack the whole object and check the SHA1..
Linus
-- VGER BF report: U 0.5