Re: [PATCH] pack-objects: re-validate data we copy from elsewhere.
Linus Torvalds <torvalds@osdl.org> writes:
Show 9 quoted lines
> On Fri, 1 Sep 2006, Junio C Hamano wrote:
>>
>> [...] Instead make sure they are not corrupt, but
>> do so only when we are not streaming to stdout, [...]
>
> Hmm. I see you making pack_to_stdout available to those functions, but I
> don't actually see you using it - looks like you revalidate regardless.
>
> Which is safe, of course, but it doesn't match your description ;)
Oops, that was a thinko. My previous crappoid had
if (pack_to_stdout)
return 0;at the beginning of revalidate function.
--
VGER BF report: U 0.499951
Junio C Hamano <junkio@cox.net>