Re: [PATCH] Speed up history generation

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 1, 2006, 01:20 UTC
Message-ID: <Pine.LNX.4.64.0606301818480.12404@g5.osdl.org>
In-Reply-To: <7v7j2ygmou.fsf@assigned-by-dhcp.cox.net>

On Fri, 30 Jun 2006, Junio C Hamano wrote:

Show 14 quoted lines

> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
> > Speed up history generation as suggested by Linus.
> > @@ -2295,16 +2295,12 @@ sub git_history {
> >  	      "</div>\n";
> >  	print "<div class=\"page_path\"><b>/" . esc_html($file_name) . "</b><br/></div>\n";
> >  
> > -	open my $fd, "-|", "$gitbin/git-rev-list $hash | $gitbin/git-diff-tree -r --stdin --
> > \'$file_name\'";
> > -	my $commit;
> > +	open my $fd, "-|", "$gitbin/git-rev-list $hash -- \'$file_name\'";
> 
> This would speed things up but at the same time it changes the
> semantics because it involves merge simplification, no?

Or just add a flag or config option that enables "--full-history" on that git-rev-list. Perhaps it should be the default fir gitweb.

With --full-history, it should still be better to do this inside git-rev-list than piping things into git-diff-tree just to limit by pathname..

		Linus