Re: [PATCH] Speed up history generation

From: Junio C Hamano <junkio@cox.net>
Date: Jul 1, 2006, 01:04 UTC
Message-ID: <7v7j2ygmou.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060701005924.7726.qmail@web31812.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

Show 9 quoted lines

> Speed up history generation as suggested by Linus.
> @@ -2295,16 +2295,12 @@ sub git_history {
>  	      "</div>\n";
>  	print "<div class=\"page_path\"><b>/" . esc_html($file_name) . "</b><br/></div>\n";
>  
> -	open my $fd, "-|", "$gitbin/git-rev-list $hash | $gitbin/git-diff-tree -r --stdin --
> \'$file_name\'";
> -	my $commit;
> +	open my $fd, "-|", "$gitbin/git-rev-list $hash -- \'$file_name\'";

This would speed things up but at the same time it changes the semantics because it involves merge simplification, no?

At least that should be noted in the commit log.