Re: [PATCH] Speed up history generation

From: Junio C Hamano <junkio@cox.net>
Date: Jul 1, 2006, 01:20 UTC
Message-ID: <7v3bdmglxo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060701011112.892.qmail@web31813.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

Show 18 quoted lines

> --- Junio C Hamano <junkio@cox.net> wrote:
>...
>> > @@ -2295,16 +2295,12 @@ sub git_history {
>> >  	      "</div>\n";
>> >  	print "<div class=\"page_path\"><b>/" . esc_html($file_name) . "</b><br/></div>\n";
>> >  
>> > -	open my $fd, "-|", "$gitbin/git-rev-list $hash | $gitbin/git-diff-tree -r --stdin --
>> > \'$file_name\'";
>> > -	my $commit;
>> > +	open my $fd, "-|", "$gitbin/git-rev-list $hash -- \'$file_name\'";
>> 
>> This would speed things up but at the same time it changes the
>> semantics because it involves merge simplification, no?
>> 
>> At least that should be noted in the commit log.
>
> Ok, I guess this should be in the log.  Can you add it please when
> commiting to the master git branch?

Well, by "at least", what I meant was that it might make sense to pass "--full-history" option to be more compatible with the original output. For graphical output like gitk, --full-history makes a mess on the screen, but a list-oriented output like gitweb it might be less confusing to show all the alternate paths that touched the path than leaving some histories out.