Re: [RFC] Cache negative delta pairs

From: Nicolas Pitre <nico@cam.org>
Date: Jun 29, 2006, 18:48 UTC
Message-ID: <Pine.LNX.4.64.0606291444370.1213@localhost.localdomain>
In-Reply-To: <20060629180719.GB4392@coredump.intra.peff.net>

On Thu, 29 Jun 2006, Jeff King wrote:

Show 8 quoted lines

> On Thu, Jun 29, 2006 at 12:39:31PM -0400, Nicolas Pitre wrote:
> 
> > You do that lookup for every delta match attempt.  Instead it could be 
> > done once for the whole window attempt, potentially reducing the cache 
> > size by a factor of 20, and it might be faster too.
> 
> I'm not convinced this will provide good cache hit characteristics, and
> I'm not convinced it's semantically correct (see my other mail).

Dare to test it? I provided you with most of the code difference already.

And what do you mean by "semantically correct"?

Nicolas