Re: [PATCH] consider previous pack undeltified object state only when reusing delta data

From: Andreas Ericsson <ae@op5.se>
Date: Jul 3, 2006, 08:11 UTC
Message-ID: <44A8D116.5070709@op5.se>
In-Reply-To: <Pine.LNX.4.64.0606301132510.1213@localhost.localdomain>

Nicolas Pitre wrote:

Show 21 quoted lines

> On Fri, 30 Jun 2006, Andreas Ericsson wrote:
> 
>>Johannes Schindelin wrote:
>>>
>>>>Without this there would never be a chance to improve packing for
>>>>previously undeltified objects.
>>>
>>>
>>>Earlier this year, I was quite surprised to learn that multiple repackings
>>>actually improved packing. Does that patch mean this feature is gone?
>>>
>>
>>The patch Linus sent removes that feature. This one re-introduces it.
> 
> 
> Not really.
> 
> Actually that multiple repacking "feature" was rather an artifact of the 
> delta data reuse code and not really by design.  Here's what happened 
> before:
>

Thanks for the extensive and very clear info. Lovely to see a competent programmer who can also explain how things work. :)

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231