Re: [RFC] Cache negative delta pairs
- From
Jeff King <peff@peff.net>
- Date
- Jun 29, 2006, 18:58 UTC
- Message-ID
- <20060629185759.GB6704@coredump.intra.peff.net>
- In-Reply-To
- <Pine.LNX.4.64.0606291444370.1213@localhost.localdomain>
On Thu, Jun 29, 2006 at 02:48:23PM -0400, Nicolas Pitre wrote:
> Dare to test it? I provided you with most of the code difference > already.
See my other mail. Unless I did something horribly wrong, caching full windows is largely useless.
> And what do you mean by "semantically correct"?
I mean that right now the cache means "calling create_delta on content that has sha1_a against content that has sha1_b will not produce a useful delta." That makes sense since the content is never going to change for a given sha1. However, covering the whole window takes into account depth and preferred base. We just need to be sure that it is correct to be including those in our cache calculation (I don't know, and I'll defer to your judgement on that, since you clearly know more about the delta logic than I do).
-Peff