Re: What's in git.git

From: Linus Torvalds <torvalds@osdl.org>
Date: May 10, 2006, 04:45 UTC
Message-ID: <Pine.LNX.4.64.0605092142050.3718@g5.osdl.org>
In-Reply-To: <864pzyh4x0.fsf@blue.stonehenge.com>

On Tue, 9 May 2006, Randal L. Schwartz wrote:

Show 14 quoted lines

> >>>>> "Junio" == Junio C Hamano <junkio@cox.net> writes:
> 
> Junio> This week's "What's in" is a day early, since I do not expect to
> Junio> be able to do much gitting for the rest of the week.
> 
> I just got this with the latest, on the git archive, using git-repack -a:
> 
> Generating pack...
> Done counting 19151 objects.
> Deltifying 19151 objects.
> Segmentation fault (core dumped)
> 
> This is on OpenBSD.  Is there a secret sabotage afoot?  This is repeatable.
> Is there anything I can try differently?

Can you see what the traceback is with gdb?

I'd suspect the deltifier changes, the rabin hash in particular. The core file traceback would probably point right at the culprit if so.

I don't see the problem myself, but if it's an access just past the end of an array or something, it would depend on exactly what the delta pattern is (which, without the "-f" flag, in turn depends on what your previous packs looked like) and also on the allocation strategy (which migth explain why it shows on OpenBSD but Linux people hadn't seen it).

			Linus