Re: What's in git.git
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- May 10, 2006, 03:48 UTC
- Message-ID
- <Pine.LNX.4.64.0605092043270.3718@g5.osdl.org>
- In-Reply-To
- <7viroezi8s.fsf@assigned-by-dhcp.cox.net>
On Tue, 9 May 2006, Junio C Hamano wrote:
Show 5 quoted lines
> > * The 'pu' branch, in addition, has the proposed configuration > file syntax updates from Linus with a patch from Sean. I > haven't had time to really look at it, and it seems to fail a > test right now, but I left it as is.
The reason for the failure is the new syntax for multi-section variables.
This patch makes the test succed, by changing
[1.2.3]
into
[1 "2.3"]
which is how subsections now end up being shown (you can still _parse_ them the old way, but they get created the new way, which is why the test fails)
That's a very strange test-case, and on the face of it the new syntax looks "worse", but if you were to be realistic about this kind of section name, it would more likely explain _what_ that number sequence means, so you would more realistically name your sections something like
[version "1.2.3"]
which I think everybody agrees looks nicer than
[version.1.2.3]
or similar.
Of course, I don't think we currently actually have any _users_ of any multi-level section names at all, so this is all entirely theoretical until we start actually using them.
Linus ---
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh index 7090ea9..54b3394 100755 --- a/t/t1300-repo-config.sh +++ b/t/t1300-repo-config.sh @@ -241,7 +241,7 @@ # empty line NoNewLine = wow2 for me [123456] a123 = 987 -[1.2.3] +[1 "2.3"] alpha = beta EOF