Re: Log message printout cleanups

From: Linus Torvalds <torvalds@osdl.org>
Date: Apr 18, 2006, 15:37 UTC
Message-ID: <Pine.LNX.4.64.0604180827040.3701@g5.osdl.org>
In-Reply-To: <7vd5ffig70.fsf@assigned-by-dhcp.cox.net>

On Mon, 17 Apr 2006, Junio C Hamano wrote:

> 
> I think this does what both of us want.  One thing I noticed is
> that log-tree-diff-flush does "---\n" under --patch-with-stat
> but not under --stat; I matched that here.

Looks very nice now. Thanks.

My only slight complaint is that I think it should be possible to do

	git log --cc --stat

to get both patches and stat, but that doesn't work. You have to write

	git log --cc --patch-with-stat

to get both ;/

But that's just a small (and unimportant) detail.

Here's another really small detail: with merges, there's two newlines between the diffstat and the diff. That bug doesn't show up with regular commits.

But this all looks very nice. I agree that "git log --stat" is a very nice way to look at the log, much better than "git-whatchanged". And the thing that has really fallen out of this all is how you can do

	git log --stat --full-diff drivers/pci/

which git-whatchanged historically didn't support (of course, now it does, but you're right, the new "git log" is so nice that I'm starting to teach myself not to use "git whatchanged" any more).

		Linus