git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fixes for option parsing

From
Linus Torvalds <torvalds@osdl.org>
Date
Apr 17, 2006, 02:42 UTC
Message-ID
<Pine.LNX.4.64.0604161938070.3701@g5.osdl.org>
In-Reply-To
<7vbqv1oxie.fsf@assigned-by-dhcp.cox.net>
On Sun, 16 Apr 2006, Junio C Hamano wrote:
> 
> In the mid-term, I am hoping we can drop the generate_header()
> callchain _and_ the custom code that formats commit log in-core,
> found in cmd_log_wc().

Maybe. I'm not convinced, though. The reason? cmd_log_wc needs to generate it regardless, for the "always" case.

Also, I think the "---" printing should be removed, and moved into the "diffstat" flushing code. Right now it does the wrong thing entirely if no diff exists, but we have always_show_header: it will print the "---" for no good reason. 

> I wish this "diff-tree SHA1 (from ANOTHERSHA1)" format can be
> dropped and replaced with "commit SHA1" format like "git log"
> does uniformly, but it might be already depended upon by
> Porcelains.

I think it might be worth just trying. A lot of the formats were pretty ad-hoc, and since everybody had their own routines, there was no reason to even try to keep them similar. Now, we'd be better off trying to make them look as close to each other as possible, and I suspect there's not a lot of porcelain that cares deeply about that format..

		Linus
Previous: Junio C HamanoNext: Linus Torvalds
Message 3 of 18 in “Fixes for option parsing”
  1. Linus TorvaldsApr 16, 2006
  2. Junio C HamanoApr 17, 2006
  3. Linus TorvaldsApr 17, 2006
  4. Linus TorvaldsApr 17, 2006
  5. Junio C HamanoApr 17, 2006
  6. Linus TorvaldsApr 17, 2006
  7. Log message printout cleanupsLinus Torvalds, Apr 17, 2006
  8. Junio C HamanoApr 17, 2006
  9. Linus TorvaldsApr 17, 2006
  10. Junio C HamanoApr 18, 2006
  11. Junio C HamanoApr 18, 2006
  12. Linus TorvaldsApr 18, 2006
  13. Junio C HamanoApr 18, 2006
  14. Linus TorvaldsApr 18, 2006
  15. Linus TorvaldsApr 18, 2006
  16. Junio C HamanoApr 18, 2006
  17. diff --stat: make sure to set recursive.Junio C Hamano, Apr 18, 2006
  18. Linus TorvaldsApr 18, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.