git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fixes for option parsing

From
Linus Torvalds <torvalds@osdl.org>
Date
Apr 17, 2006, 14:51 UTC
Message-ID
<Pine.LNX.4.64.0604170747580.3701@g5.osdl.org>
In-Reply-To
<7vu08soou3.fsf@assigned-by-dhcp.cox.net>
On Sun, 16 Apr 2006, Junio C Hamano wrote:
> 
> I am not sure if that belongs to diffstat flush.  I was instead
> planning to  move it to diff-flush code
Well, that's broken right now with the stat part, for some reason.
> and show it only when we actually show any diffs.  IOW, I think we would 
> want it even when we are doing "--pretty -p", not "--pretty 
> --patch-with-stat".

I'd personally prefer to see it only in front of diffstat, and leave the patches the way they have been before. For patches, I find the indentation of the commit message to be visually (a) much more pleasing and (b) more pronounced than a "---" anyway.

Perhaps configurable? git-format-patch doesn't want the indentation (and thus "---" makes sense for both patches and diffstat), while "git log" definitely does, because it's much more visually clear _and_ it makes the header/comment structure totally unambiguous.

			Linus
Previous: Junio C HamanoNext: Linus Torvalds
Message 6 of 18 in “Fixes for option parsing”
  1. Linus TorvaldsApr 16, 2006
  2. Junio C HamanoApr 17, 2006
  3. Linus TorvaldsApr 17, 2006
  4. Linus TorvaldsApr 17, 2006
  5. Junio C HamanoApr 17, 2006
  6. Linus TorvaldsApr 17, 2006
  7. Log message printout cleanupsLinus Torvalds, Apr 17, 2006
  8. Junio C HamanoApr 17, 2006
  9. Linus TorvaldsApr 17, 2006
  10. Junio C HamanoApr 18, 2006
  11. Junio C HamanoApr 18, 2006
  12. Linus TorvaldsApr 18, 2006
  13. Junio C HamanoApr 18, 2006
  14. Linus TorvaldsApr 18, 2006
  15. Linus TorvaldsApr 18, 2006
  16. Junio C HamanoApr 18, 2006
  17. diff --stat: make sure to set recursive.Junio C Hamano, Apr 18, 2006
  18. Linus TorvaldsApr 18, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.