Re: [PATCH] Add ALL_LDFLAGS to the git target.

From: Linus Torvalds <torvalds@osdl.org>
Date: Mar 28, 2006, 23:03 UTC
Message-ID: <Pine.LNX.4.64.0603281500280.15714@g5.osdl.org>
In-Reply-To: <slrne2jf9t.s3g.mdw@metalzone.distorted.org.uk>

On Tue, 28 Mar 2006, Mark Wooding wrote:

Show 9 quoted lines

> Jason Riedy <ejr@EECS.Berkeley.EDU> wrote:
> 
> > P.S. For the whole finding-a-function-name business, some of 
> > us are using git on fixed-format Fortran.  Every non-comment
> > line begins with whitespace...  ;)  And in free format, many
> > people don't add that first indentation within subroutines.
> 
> Urgh.  So, which regex library do people want to use? ;-)  (My vote's
> for pcre.)

I'd really just prefer to make the "-p" switch configurable, the way it was before. No regexps, just the same rules as for GNU diff, perhaps with the difference being that it would be on by default.

Another possible approach is to say
 - if the first line of the real diff matches the rules, do NOT add 
   another line that matches the rule at the @@-line.

since the simple @@-line rule really doesn't make sense for any file that is "dense" (ie where most lines start with non-whitespace).

		Linus