Re: Gitk strangeness..

From: Linus Torvalds <torvalds@osdl.org>
Date: Mar 28, 2006, 02:57 UTC
Message-ID: <Pine.LNX.4.64.0603271856070.15714@g5.osdl.org>
In-Reply-To: <17448.40941.256361.866229@cargo.ozlabs.ibm.com>

On Tue, 28 Mar 2006, Paul Mackerras wrote:

>
> The other option would be to make git-rev-list list the open-circle
> commits explicitly, with an indication that they are not in the
> requested set but are parents of commits in the requested set.

Just as an indication of _how_ simple that is, here's a stupid patch.

It just puts a "-" after a parent that isn't going to be shown.

Play with it (and it probably needs a new flag to enable it, since doing it unconditionally like this will break old versions of gitk and probably anything else that uses the "--parent" flag).

		Linus

----

diff --git a/rev-list.c b/rev-list.c
index 441c437..822a740 100644
--- a/rev-list.c
+++ b/rev-list.c
@@ -60,6 +60,8 @@
 			if (o->flags & TMP_MARK)
 				continue;
 			printf(" %s", sha1_to_hex(o->sha1));
+			if (o->flags & UNINTERESTING)
+				putchar('-');
 			o->flags |= TMP_MARK;
 		}
 		/* TMP_MARK is a general purpose flag that can