git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Tie it all together: "git log"

From
Linus Torvalds <torvalds@osdl.org>
Date
Feb 28, 2006, 20:59 UTC
Message-ID
<Pine.LNX.4.64.0602281251390.22647@g5.osdl.org>
In-Reply-To
<Pine.LNX.4.64.0602281126340.22647@g5.osdl.org>
On Tue, 28 Feb 2006, Linus Torvalds wrote:
Show 5 quoted lines
> 
> Again, this may not do exactly what the current "git log" does. That's not 
> the point. The point is to introduce the fundamental functionality, so 
> that people can play with this and improve on it, and fix any of my stupid 
> bugs.

Btw, before anybody even pipes up: the missing piece here is the nasty "filter_commit()" that rev-list.c does, and that really should be moved into revision.c, and this is where I hit on the "--merge-order" issues.

So for example, if you do "git log -- <filename>" with the new git, it won't filter out the commits that just change the passed-in <filename> properly, because the filtering code still exists only in git-rev-list (even if revision.c now does the traversal).

Same goes for the max-count-based filtering, for the same reason.

So the "process_commit()" handling should be moved into "get_revision()", but since the merge-order code also hooks into it...

Anyway, apart from that issue (which I think should be trivial to sort out if we accept breaking --merge-order), the rest looks like it should just get more testing and handling of the few missing flags from rev-parse in revision.c, and it should be good.

		Linus
Previous: Linus TorvaldsNext: Junio C Hamano
Message 5 of 13 in “git-rev-list libification effort: the next stage”
  1. 0/3 git-rev-list libification effort: the next stageLinus Torvalds, Feb 28, 2006
  2. 1/3 git-rev-list libification: rev-list walkingLinus Torvalds, Feb 28, 2006
  3. 2/3 Introduce trivial new pager.c helper infrastructureLinus Torvalds, Feb 28, 2006
  4. 3/3 Tie it all together: "git log"Linus Torvalds, Feb 28, 2006
  5. Linus TorvaldsFeb 28, 2006
  6. Junio C HamanoFeb 28, 2006
  7. Linus TorvaldsFeb 28, 2006
  8. 1/2 git-log (internal): add approxidate.Junio C Hamano, Mar 1, 2006
  9. 2/2 git-log (internal): more options.Junio C Hamano, Mar 1, 2006
  10. Linus TorvaldsMar 1, 2006
  11. Junio C HamanoMar 1, 2006
  12. Martin LanghoffFeb 28, 2006
  13. Junio C HamanoMar 1, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.