[PATCH 3/3] Tie it all together: "git log"
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Feb 28, 2006, 19:30 UTC
- Message-ID
- <Pine.LNX.4.64.0602281126340.22647@g5.osdl.org>
- In-Reply-To
- <Pine.LNX.4.64.0602281115110.22647@g5.osdl.org>
This is what the previous diffs all built up to.
We can do "git log" as a trivial small helper function inside git.c, because the infrastructure is all there for us to use as a library.
Signed-off-by: Linus Torvalds <torvalds@osdl.org> ----
Again, this may not do exactly what the current "git log" does. That's not the point. The point is to introduce the fundamental functionality, so that people can play with this and improve on it, and fix any of my stupid bugs.
It should be pretty easy to change some of the other rev-list-walking functions to use the library interfaces too, instead of executing an external "git-rev-list" process. This was a perfect example of how to get something working, though.
Linus
diff --git a/Makefile b/Makefile index 0b1a998..ead13be 100644 --- a/Makefile +++ b/Makefile @@ -450,7 +450,7 @@ strip: $(PROGRAMS) git$X git$X: git.c $(LIB_FILE) $(CC) -DGIT_VERSION='"$(GIT_VERSION)"' \ - $(CFLAGS) $(COMPAT_CFLAGS) -o $@ $(filter %.c,$^) $(LIB_FILE) + $(ALL_CFLAGS) -o $@ $(filter %.c,$^) $(LIB_FILE) $(LIBS) $(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh rm -f $@ diff --git a/git.c b/git.c index 993cd0d..b0da6b1 100644 --- a/git.c +++ b/git.c @@ -12,6 +12,10 @@ #include "git-compat-util.h" #include "exec_cmd.h" +#include "cache.h" +#include "commit.h" +#include "revision.h" + #ifndef PATH_MAX # define PATH_MAX 4096 #endif @@ -245,6 +249,25 @@ static int cmd_help(int argc, char **arg return 0; } +#define LOGSIZE (65536) + +static int cmd_log(int argc, char **argv, char **envp) +{ + struct rev_info rev; + struct commit *commit; + char *buf = xmalloc(LOGSIZE); + + argc = setup_revisions(argc, argv, &rev, "HEAD"); + prepare_revision_walk(&rev); + setup_pager(); + while ((commit = get_revision(&rev)) != NULL) { + pretty_print_commit(CMIT_FMT_DEFAULT, commit, ~0, buf, LOGSIZE, 18); + printf("%s\n", buf); + } + free(buf); + return 0; +} + #define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0])) static void handle_internal_command(int argc, char **argv, char **envp) @@ -256,6 +279,7 @@ static void handle_internal_command(int } commands[] = { { "version", cmd_version }, { "help", cmd_help }, + { "log", cmd_log }, }; int i;