Re: [Cogito] Various bugs

From: Linus Torvalds <torvalds@osdl.org>
Date: Feb 7, 2006, 16:56 UTC
Message-ID: <Pine.LNX.4.64.0602070854380.3854@g5.osdl.org>
In-Reply-To: <20060207164946.GN31278@pasky.or.cz>

On Tue, 7 Feb 2006, Petr Baudis wrote:

Show 9 quoted lines

> 
> > Yes. That said, we should probably disallow that in git-commit-tree (and 
> > let the user fix it up some way).
> 
> What way? Sometimes you just receive mails from people who have only
> email addy in the from line, or you can be importing from some other VCS
> where the mapping does not exist and the importers may not deem it
> necessary to have it in GIT. Sure, it may be kernel policy to disallow
> this, but I wouldn't enforce this for all projects in GIT.

Umm. Having an empty name is _wrong_. It makes things like the shortlogs break.

Yes, it has happened in the kernel a few times, but those were bugs, and I'd have been very happy if git-write-tree had just aborted on me.

If you don't have any better name than the email/user-name, just use that (but at least for the kernel, I'd much prefer a round of "google" first to see if something better is available). An _empty_ name is never acceptable.

		Linus