Re: [Cogito] Various bugs

From

Junio C Hamano <junkio@cox.net>

Date

Feb 7, 2006, 20:49 UTC

Message-ID

<7v8xsmvqqp.fsf@assigned-by-dhcp.cox.net>

In-Reply-To

<Pine.LNX.4.64.0602070751410.3854@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

> An empty GIT_AUTHOR_NAME should _not_ mean that we use the default name 
> (which is usually the committer), because rather than meaning "default", 
> it most likely means "buggy import script". 
>
> I'd rather have an email import of mine say that it cannot commit, than 
> have it put "Linus Torvalds" in the author line (and some random email).

I am inclined to agree.  Something like this?

---

diff --git a/ident.c b/ident.c
index 0461b8b..23b8cfc 100644
--- a/ident.c
+++ b/ident.c
@@ -167,6 +167,11 @@ static const char *get_ident(const char 
 		name = git_default_name;
 	if (!email)
 		email = git_default_email;
+
+	if (!*name || !*email)
+		die("empty ident %s <%s> not allowed",
+		    name, email);
+
 	strcpy(date, git_default_date);
 	if (date_str)
 		parse_date(date_str, date, sizeof(date));