Re: [Cogito] Various bugs
- From
Petr Baudis <pasky@suse.cz>
- Date
- Feb 7, 2006, 16:49 UTC
- Message-ID
- <20060207164946.GN31278@pasky.or.cz>
- In-Reply-To
- <Pine.LNX.4.64.0602070751410.3854@g5.osdl.org>
Dear diary, on Tue, Feb 07, 2006 at 04:53:57PM CET, I got a letter where Linus Torvalds <torvalds@osdl.org> said that...
Show 16 quoted lines
> > > On Mon, 6 Feb 2006, Junio C Hamano wrote: > > > > It depends on what you expect, but it meets _my_ expectation: > > > > $ GIT_AUTHOR_NAME='' git-commit-tree $(git-write-tree) </dev/null > > Committing initial tree a2b59c3848164a2c9c3c75fbaadccaed9485da92 > > ef90563fa278735af367e7606ea7eb2559121ca7 > > $ git-cat-file commit ef90563fa278735af367e7606ea7eb2559121ca7 > > tree a2b59c3848164a2c9c3c75fbaadccaed9485da92 > > author <junkio@cox.net> 1139281078 -0800 > > committer Junio C Hamano <junkio@cox.net> 1139281078 -0800 > > > > That is, the user said GIT_AUTHOR_NAME is empty, so he gets a > > commit with an empty author name.
That is what I expect and I must have done something wrong the last night since it works for me now as well. Sorry. So I'm all alone at this bug again. ;-)
> Yes. That said, we should probably disallow that in git-commit-tree (and > let the user fix it up some way).
What way? Sometimes you just receive mails from people who have only email addy in the from line, or you can be importing from some other VCS where the mapping does not exist and the importers may not deem it necessary to have it in GIT. Sure, it may be kernel policy to disallow this, but I wouldn't enforce this for all projects in GIT.
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ Of the 3 great composers Mozart tells us what it's like to be human, Beethoven tells us what it's like to be Beethoven and Bach tells us what it's like to be the universe. -- Douglas Adams