git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Remove more parsers

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Jan 29, 2006, 22:05 UTC
Message-ID
<Pine.LNX.4.64.0601291645060.25300@iabervon.org>
In-Reply-To
<7vk6ciixv0.fsf@assigned-by-dhcp.cox.net>
On Sun, 29 Jan 2006, Junio C Hamano wrote:
Show 8 quoted lines
> I do not have objections to git-tar-tree changes, but I am
> hesitant to use the tree parser in diff-tree due to its memory
> retention behaviour.  We already use the commit parser in
> diff-tree but I think we currently do not ask for the tree part
> of the object to be parsed.  I suspect this patch would badly
> interact with long-running "diff-tree --stdin", which is the
> workhorse of whatchanged.  I haven't benched it though, and I'd
> be happy to see the impact is proven to be negligible.

I'll look into discarding the struct trees after use (since we're not keeping flags on them, or storing references to them long-term), so we can use the same parser without worse memory behavior. It does seem to take a bunch more memory (and, oddly, be very slow) as I currently have it.

	-Daniel
*This .sig left intentionally blank*
Previous: Junio C HamanoNext: Linus Torvalds
Message 10 of 11 in “Remove more parsers”
  1. 0/3 Remove more parsersDaniel Barkalow, Jan 29, 2006
  2. 1/3 Use struct tree in tar-treeDaniel Barkalow, Jan 29, 2006
  3. 2/3 Use struct commit in tar-treeDaniel Barkalow, Jan 29, 2006
  4. 3/3 Use struct tree in diff-treeDaniel Barkalow, Jan 29, 2006
  5. Linus TorvaldsJan 31, 2006
  6. Junio C HamanoJan 31, 2006
  7. Daniel BarkalowJan 31, 2006
  8. Linus TorvaldsJan 31, 2006
  9. Junio C HamanoJan 29, 2006
  10. Daniel BarkalowJan 29, 2006
  11. Linus TorvaldsJan 31, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.