Re: [PATCH 3/3] Use struct tree in diff-tree

From: Junio C Hamano <junkio@cox.net>
Date: Jan 31, 2006, 21:20 UTC
Message-ID: <7virs0uma8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0601310846380.7301@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 11 quoted lines

> On Sun, 29 Jan 2006, Daniel Barkalow wrote:
>>
>> It had been open-coding a tree parser. This updates the programs that
>> call diff_tree() to send it the struct tree instead of a buffer and
>> size.
>
> Please don't.
> ...
> Junio, please don't apply this.
>
> 		Linus

I haven't, and I won't. From my gut feeling I did not even place it in "pu". After timing it myself and then looking at the code I agree with your analysis.

The one to git-tar-tree I've already applied, mostly because I was not careful enough and especially I did not care enough about performance of that program. On my slow machine the tip of kernel before you came back takes 9.2 seconds wallclock as opposed to 8.7 seconds to tar up, so the patch degrades the performance by about 5%. Maybe we would want to revert that one as well.