Re: [PATCH 0/3] Remove more parsers
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jan 29, 2006, 20:26 UTC
- Message-ID
- <7vk6ciixv0.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0601291336420.25300@iabervon.org>
I do not have objections to git-tar-tree changes, but I am hesitant to use the tree parser in diff-tree due to its memory retention behaviour. We already use the commit parser in diff-tree but I think we currently do not ask for the tree part of the object to be parsed. I suspect this patch would badly interact with long-running "diff-tree --stdin", which is the workhorse of whatchanged. I haven't benched it though, and I'd be happy to see the impact is proven to be negligible.