Re: [PATCH 2/3] git-bundle: die if a given ref is not included in bundle

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 11, 2007, 01:08 UTC
Message-ID: <Pine.LNX.4.63.0703110201450.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <45F2F934.8060407@gmail.com>

Hi,

On Sat, 10 Mar 2007, Mark Levedahl wrote:

Show 16 quoted lines

> Johannes Schindelin wrote:
>
> > So, what do you do if some of your users do, and some others do not, 
> > have the "blue-sky" branch? If you say "git bundle create new.bundle 
> > --all -10", your bundle will list "blue-sky" as a prerequisite.
> > 
> > Boom.
> > 
> > Some of your users -- those without "blue-sky" -- will _not_ be able 
> > to fetch _anything_ from the bundle. They are lacking the 
> > prerequisites.
>
> Those who have the prerequisites can apply the bundle. Those who do not, 
> cannot. This is unchanged, and completely unrelated to whether the 
> bundle defines 0 objects or 10,000. If you do not have the 
> prerequisites, you need a different bundle.

Only that I suspect that you want to stick more than one ref into the bundle. And at some point you -- or any other user -- will expect the bundle to work _with several refs_, even if different recipients will pick _only one_ of them.

Basically, I am saying that this whole bundle concept is not thought through, that it is too loosely defined, and that it will result in unmet expectations sooner or later. (Which usually means sooner.)

So, either we have to rethink how to handle prerequisites (so that only those are checked which are strictly necessary for _the one_ ref you are updating), or we have to make it _very_ obvious to (human) users of git-bundle that you should _not_ bundle two unrelated -- or only remotely related -- refs into one bundle.

Ciao, Dscho