[PATCH 2/3] git-bundle: die if a given ref is not included in bundle
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 9, 2007, 02:48 UTC
- Message-ID
- <Pine.LNX.4.63.0703090348300.22628@wbgn013.biozentrum.uni-wuerzburg.de>
The earlier patch tried to be nice by just warning, but it seems more likely that the user wants to adjust the parameters.
Also, it prevents a bundle containing _all_ revisions in the case when the user only gave one ref, but also rev-list options which excluded the ref.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> ---
It really was a dumb idea not to error out there. Sorry.
builtin-bundle.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/builtin-bundle.c b/builtin-bundle.c index 33b533f..ca3de60 100644 --- a/builtin-bundle.c +++ b/builtin-bundle.c @@ -328,11 +328,9 @@ static int create_bundle(struct bundle_header *header, const char *path, * other limiting options could have prevented all the tips * from getting output. */ - if (!(e->item->flags & SHOWN)) { - warn("ref '%s' is excluded by the rev-list options", + if (!(e->item->flags & SHOWN)) + die("ref '%s' is excluded by the rev-list options", e->name); - continue; - } write_or_die(bundle_fd, sha1_to_hex(e->item->sha1), 40); write_or_die(bundle_fd, " ", 1); write_or_die(bundle_fd, ref, strlen(ref));
-- 1.5.0.3.2601.gc1e5-dirty