Re: [PATCH 2/3] git-bundle: die if a given ref is not included in bundle
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 10, 2007, 15:39 UTC
- Message-ID
- <Pine.LNX.4.63.0703101637300.22628@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <7v1wjy56qf.fsf@assigned-by-dhcp.cox.net>
Hi,
On Fri, 9 Mar 2007, Junio C Hamano wrote:
Show 24 quoted lines
> Mark Levedahl <mlevedahl@gmail.com> writes: > > > git>git bundle create t.bdl master --not master > > Generating pack... > > Done counting 0 objects. > > Writing 0 objects. > > Total 0 (delta 0), reused 0 (delta 0) > > git>git ls-remote t.bdl > > git> > > > > e.g, an empty bundle is created without any error or warning. This is > > the one case I believe an error should result: there is no use to > > sending (or even creating) an empty bundle. > > I agree that erroring on an empty output is a sensible _option_ > just like pack-objects has --no-empty option. > > The above is actually an interesting example in a different > sense. When somebody did the following, what should be output? > > $ edit; git commit -a ;# on master > $ git checkout -b side > $ edit; git commit -a ;# on side > $ git bundle create foo.bdl master side ^master
IMHO saying "master ^master" should blow into the user's face. If she says "I want it" _and_ "I don't want it", she should sorta expect it not to work.
Ciao, Dscho