Re: [PATCH] git-bundle: fix pack generation.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 7, 2007, 22:35 UTC
Message-ID: <Pine.LNX.4.63.0703072330200.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <30e4a070703070834s3dd5bdd7x2e1639aa2979d1cf@mail.gmail.com>

Hi,

On Wed, 7 Mar 2007, Mark Levedahl wrote:

Show 11 quoted lines

> On 3/6/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > 
> > > git-bundle create test.bdl HEAD --since=1.day.ago ==>> pack with 
> > > 1531 objects
> > 
> > Did you test with "--since=1.day.ago HEAD", i.e. with the correct 
> > order? I know you'd like the options to be interminglable, but "HEAD" 
> > really is not an option, but an argument.
> 
> Changing the order of arguments makes no difference, same result either 
> way.

We don't do thin packs. Should we? I guess that

	$ git ls-tree -r HEAD | wc

results in something close to 1500 in that repo. Which basically means that the 1531 objects (including trees and the commit) sounds correct.

Of course, we _could_ make the packs thin, but the disadvantage would be that we can never decide at a later stage to allow shallow fetches from that bundle.

The advantage of the thin packs would be that the bundles would be much smaller.

Ciao, Dscho